On 06/04/2017 11:35 PM, Goldwyn Rodrigues wrote:
> @@ -1900,6 +1905,17 @@ generic_make_request_checks(struct bio *bio)
>               goto end_io;
>       }
>  
> +     /*
> +      * For a REQ_NOWAIT based request, return -EOPNOTSUPP
> +      * if queue does not have QUEUE_FLAG_NOWAIT_SUPPORT set
> +      * and if it is not a request based queue.
> +      */
> +
> +     if ((bio->bi_opf & REQ_NOWAIT) && !queue_is_rq_based(q)) {
> +             err = -EOPNOTSUPP;
> +             goto end_io;
> +     }

There is no QUEUE_FLAG_NOWAIT, this looks like a somewhat stale comment.

This patch should be prefixed with 'block', not 'fs'.

-- 
Jens Axboe

Reply via email to