On Mon, Jun 19, 2017 at 3:26 PM, Christoph Hellwig <h...@lst.de> wrote: > pktcdvd is a make_request based stacking driver and thus doesn't have any > addressing limits on it's own. It also doesn't use bio_data() or > page_address(), so it doesn't need a lowmem bounce either. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- > drivers/block/pktcdvd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c > index 26c04baae967..7f2eca31eb6a 100644 > --- a/drivers/block/pktcdvd.c > +++ b/drivers/block/pktcdvd.c > @@ -2413,8 +2413,6 @@ static blk_qc_t pkt_make_request(struct request_queue > *q, struct bio *bio) > char b[BDEVNAME_SIZE]; > struct bio *split; > > - blk_queue_bounce(q, &bio); > - > blk_queue_split(q, &bio); > > pd = q->queuedata; > -- > 2.11.0 >
blk_queue_make_request() sets bounce for any highmem page for long time, and in theory this patch might cause regression on 32bit arch, when the controller can't handle higmem page really(especially in case of PAE), so we may need to be careful about this change, especially on some old hardware. thanks, Ming Lei
