On 06/19/2017 12:28 AM, Christoph Hellwig wrote:
> On Sat, Jun 17, 2017 at 01:59:49PM -0600, Jens Axboe wrote:
>> Reviewed-by: Andreas Dilger <adil...@dilger.ca>
>> Signed-off-by: Jens Axboe <ax...@kernel.dk>
>> ---
>> fs/block_dev.c | 2 ++
>> fs/direct-io.c | 2 ++
>> fs/iomap.c | 1 +
>> 3 files changed, 5 insertions(+)
>>
>> diff --git a/fs/block_dev.c b/fs/block_dev.c
>> index 519599dddd36..b9222a9d285e 100644
>> --- a/fs/block_dev.c
>> +++ b/fs/block_dev.c
>> @@ -239,6 +239,7 @@ __blkdev_direct_IO_simple(struct kiocb *iocb, struct
>> iov_iter *iter,
>> should_dirty = true;
>> } else {
>> bio.bi_opf = dio_bio_write_op(iocb);
>> + bio.bi_opf |= write_hint_to_opf(iocb_write_hint(iocb));
>
> Move this into dio_bio_write_op instead of duplicating it?
Good cleanup, will do.
--
Jens Axboe
