On Wed, Jul 05, 2017 at 09:53:08AM +0300, Sagi Grimberg wrote: > When we requeue a request, we can always insert the request > back to the scheduler instead of doing it when restarting > the queues and kicking the requeue work, so get rid of > the requeue kick in nvme (core and drivers). > > Also, now there is no need start hw queues in nvme_kill_queues > We don't stop the hw queues anymore, so no need to > start them. > > Signed-off-by: Sagi Grimberg <[email protected]> > --- > drivers/nvme/host/core.c | 19 ++----------------- > drivers/nvme/host/fc.c | 4 +--- > drivers/nvme/host/pci.c | 1 - > drivers/nvme/host/rdma.c | 1 - > 4 files changed, 3 insertions(+), 22 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index d70df1d0072d..48cafaa6fbc5 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -131,7 +131,7 @@ void nvme_complete_rq(struct request *req) > { > if (unlikely(nvme_req(req)->status && nvme_req_needs_retry(req))) { > nvme_req(req)->retries++; > - blk_mq_requeue_request(req, !blk_mq_queue_stopped(req->q)); > + blk_mq_requeue_request(req, true); > return; > }
This change is correct. -- Ming
