On Fri, Aug 04, 2017 at 09:04:21AM -0600, Jens Axboe wrote:
> Modify blk_mq_in_flight() to count both a partition and root at
> the same time. Then we only have to call it once, instead of
> potentially looping the tags twice.

Reviewed-by: Omar Sandoval <osan...@fb.com>

One comment below.

> Signed-off-by: Jens Axboe <ax...@kernel.dk>

[snip]

> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index fe1aa1f5f069..410ed246bc9b 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -98,11 +98,13 @@ static void blk_mq_check_inflight(struct blk_mq_hw_ctx 
> *hctx,
>               return;
>  
>       /*
> -      * Count as inflight if it either matches the partition we asked
> -      * for, or if it's the root
> +      * Count as inflight if it matches the partition, count separately
> +      * (but all) if we got asked for the root
>        */
> -     if (rq->part == mi->part || mi->part->partno)
> +     if (rq->part == mi->part)
>               mi->inflight[0]++;

Similar concern as with patch 3, why special case the part0 case below?

> +     if (mi->part->partno)
> +             mi->inflight[1]++;
>  }

Reply via email to