On Fri, Aug 18, 2017 at 03:07:33PM +0200, Milan Broz wrote: > The commit f2c6df7dbf9a60e1cd9941f9fb376d4d9ad1e8dd > > loop: support 4k physical blocksize > > adds support for loop block size with only specific block sizes. > > If the size is not supported, the code returns -EINVAL keeping > the loop queue frozen. This causes that device could be locked > for a long time by processes trying to scan device (udev). > (And also causing subsequent LOOP_CLR_FD operations noop.) > > Fix it by using goto to proper exit location with queue unfreeze. > > (The same bug is for setting crypt attribute but this code is > probably no more used. Patch fixes it as well though.) > > Signed-off-by: Milan Broz <[email protected]>
Heh, I sent the same patch [1] only hours before :) v2 is here [2] if you want to give it a reviewed-by. 1: https://marc.info/?l=linux-block&m=150303694018659&w=2 2: https://marc.info/?l=linux-block&m=150308446732748&w=2
