On Thu, Sep 07, 2017 at 05:16:21PM +0800, Ming Lei wrote: > On Thu, Sep 7, 2017 at 8:13 AM, Shaohua Li <[email protected]> wrote: > > From: Shaohua Li <[email protected]> > > > > We don't know if fallocate really supports FALLOC_FL_PUNCH_HOLE till > > fallocate is called. If it doesn't support, loop will return -EOPNOTSUPP > > and we see a lot of error message printed by blk_update_request. Failure > > for discard IO isn't a big problem, so we just return 0 in loop which > > will suppress the IO error message. > > Setting RQF_QUIET for discard IO should be more clean for suppressing error, > and upper layer can get the failure notification too.
Hmm, forgot why I didn't do this, did consider it before. Probably because nobody check the return value of discard request. Probably we should skip the error message for all discard IO in block layer. I'll repost a patch to fix this issue. Thanks, Shaohua
