From: 10074136 <[email protected]> > Code comments in alloc.c:bch_alloc_sectors() mentions a function > name find_data_bucket(), the correct function name should be > pick_data_bucket() indeed. bch_alloc_sectors() is a quite important > function in bcache allocation code, fixing the typo may help > other people to have less confusion. > > Signed-off-by: Coly Li <[email protected]> > --- > drivers/md/bcache/alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c > index cacbe2dbd5c3..071ff28be912 100644 > --- a/drivers/md/bcache/alloc.c > +++ b/drivers/md/bcache/alloc.c > @@ -600,7 +600,7 @@ bool bch_alloc_sectors(struct cache_set *c, struct bkey > *k, unsigned sectors, > > /* > * If we had to allocate, we might race and not need to > allocate the > - * second time we call find_data_bucket(). If we allocated a > bucket but > + * second time we call pick_data_bucket(). If we allocated a > bucket but > * didn't use it, drop the refcount bch_bucket_alloc_set() > took: > */ > if (KEY_PTRS(&alloc.key))
Yes, It's useful for code reading, Thanks. Reviewed-by: Tang Junhui <[email protected]>
