> On 6 Oct 2017, at 13.59, Christoph Hellwig <h...@infradead.org> wrote: > > On Fri, Oct 06, 2017 at 11:19:09AM +0200, Javier González wrote: >> on the lightnvm I/O path and that has propagated through the code as we >> added more functionality. Can you explain why this is necessary? If I >> can just remove it, it is much easier to do the cleanup. >> >> I have tested on or HW and all works fine without it. > > nvme_alloc_request always sets REQ_FAILFAST_DRIVER and that srops > it to stick to the previous behavior. > > If you actually want all your lightnvm requests to fail fast you can > remove it.
I think it is good to fail fast as any other nvme I/O command and then recover in pblk if necessary. Thanks Christoph! Javier
signature.asc
Description: Message signed with OpenPGP
