On 2017/10/17 上午1:39, Michael Lyle wrote: > Hey Coly-- > > On Thu, Sep 21, 2017 at 12:54 PM, Coly Li <[email protected]> wrote: >> When bcache does read I/Os, for example in writeback or writethrough mode, >> if a read request on cache device is failed, bcache will try to recovery >> the request by reading from cached device. If the data on cached device is >> not synced with cache device, then requester will get a stale data. > [...] >> + if (s->recoverable && >> + (dc && !atomic_read(&dc->has_dirty)) { > > Looks like this is missing a parens.
Hi Mike, Oops, I am blind ... Thanks for figure out this. V4 patch is out, and I think you may change Acked-by to Reviewed-by, because you reviewed the code and pointed out problem :-) Thanks. -- Coly Li
