On Wed, Oct 11, 2017 at 03:04:14PM +0300, Sagi Grimberg wrote:
>
>> +/*
>> + * Anchor structure for namespaces. There is one for each namespace in a
>> + * NVMe subsystem that any of our controllers can see, and the namespace
>> + * structure for each controller is chained of it. For private namespaces
>> + * there is a 1:1 relation to our namespace structures, that is ->list
>> + * only ever has a single entry for private namespaces.
>> + */
>> +struct nvme_ns_head {
>> + struct list_head list;
>
> Didn't we agree to call this list_head siblings?
Don't think I did.
>> struct nvme_ctrl *ctrl;
>> struct request_queue *queue;
>> struct gendisk *disk;
>> + struct list_head siblings;
>
> And this list_head list (or entry, or sibling, or sibling_entry)?
I think siblings fits perfectly fine. It is a lot more descriptive
than entry..
