xiao yang <[email protected]> writes:

> +requires() {
> +     _have_program mkfs.ext3
> +}
[...]
> +     # Format
> +     mkfs.ext3 -F "$TEST_DEV" >> "$FULL" 2>&1

What's the reason to limit the test case to ext3 only? Can you switch it
to the generic 'mkfs' command? IIRC we require 'util-linux' to be
present for blktests but mkfs.ext3 is (at least in SUSE based distros)
in the e2fsprogs package.

apart from that:
Reviewed-by: Johannes Thumshirn <[email protected]>

-- 
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Reply via email to