On Tue, Jan 09, 2018 at 10:38:58AM -0700, Keith Busch wrote:
> On Mon, Jan 08, 2018 at 01:57:07AM -0800, Christoph Hellwig wrote:
> > > - if (unlikely(nvme_req(req)->status && nvme_req_needs_retry(req))) {
> > > - if (nvme_req_needs_failover(req)) {
> > > + blk_status_t status = nvme_error_status(req);
> > > +
> > > + if (unlikely(status != BLK_STS_OK && nvme_req_needs_retry(req))) {
> > > + if (nvme_req_needs_failover(req, status)) {
> >
> > We don't really need to call nvme_error_status if nvme_req(req)->status
> > is zero.
>
> We are already calling nvme_error_status unconditionally for
> blk_mq_end_request, so we currently read nvme_req(req)->status multiple
> times in the completion path. I think we'd prefer to read it just once.
Indeed. Objection retracted.
