On Tue, 2018-02-13 at 09:43 +0100, Johannes Thumshirn wrote:
> On Mon, 2018-02-12 at 11:05 -0800, Bart Van Assche wrote:
> > +/*
> > + * Variables of type sector_t represent an offset or size that is a
> > multiple of
> > + * 2**9 bytes. Hence these two constants.
> > + */
> > +#ifndef SECTOR_SHIFT
> > +enum { SECTOR_SHIFT = 9 };
> > +#endif
> > +#ifndef SECTOR_SIZE
> > +enum { SECTOR_SIZE = 512 };
> > +#endif
> 
> Can you please make a #define out of these enums? I know gdb can cope
> better with enums than defines but IIRC adding -ggdb3 to the CFLAGS
> solves this issue.
> 
> Apart from that:
> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

OK, I will change the enums into defines.

Thanks for the review.

Bart.


Reply via email to