Bart, > It happens often while I'm preparing a patch for a block driver that > I'm wondering: is a definition of SECTOR_SIZE and/or SECTOR_SHIFT > available for this driver? Do I have to introduce definitions of these > constants before I can use these constants? To avoid this confusion, > move the existing definitions of SECTOR_SIZE and SECTOR_SHIFT into the > <linux/blkdev.h> header file such that these become available for all > block drivers. Make the SECTOR_SIZE definition in the uapi msdos_fs.h > header file conditional to avoid that including that header file after > <linux/blkdev.h> causes the compiler to complain about a SECTOR_SIZE > redefinition.
Looks good. Reviewed-by: Martin K. Petersen <[email protected]> -- Martin K. Petersen Oracle Linux Engineering
