Sorry- I had to pull/unapply this actually.

On 03/04/2018 11:40 PM, Chengguang Xu wrote:
> -static struct dentry *debug
> +struct dentry *debug;

This conflicts with other symbols called "debug" and doesn't compile.
Please be sure that your patch set compiles before submitting.

Mike

>  
>  #ifdef CONFIG_BCACHE_DEBUG
>  
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 1a9fdab..b784292 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -2133,7 +2133,6 @@ static int __init bcache_init(void)
>       mutex_init(&bch_register_lock);
>       init_waitqueue_head(&unregister_wait);
>       register_reboot_notifier(&reboot);
> -     closure_debug_init();
>  
>       bcache_major = register_blkdev(0, "bcache");
>       if (bcache_major < 0) {
> @@ -2145,7 +2144,7 @@ static int __init bcache_init(void)
>       if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||
>           !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||
>           bch_request_init() ||
> -         bch_debug_init(bcache_kobj) ||
> +         bch_debug_init(bcache_kobj) || closure_debug_init() ||
>           sysfs_create_files(bcache_kobj, files))
>               goto err;
>  
> 

Reply via email to