On 3/12/2018 3:35 PM, Logan Gunthorpe wrote:
> -     if (nvmeq->sq_cmds_io)

I think you should keep the code as it is for the case where
(!nvmeq->sq_cmds_is_io && nvmeq->sq_cmds_io)

You are changing the behavior for NVMe drives with CMB buffers.
You can change the if statement here with the statement above.

> -             memcpy_toio(&nvmeq->sq_cmds_io[tail], cmd, sizeof(*cmd));
> -     else
> -             memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));
> +     memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));

Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux 
Foundation Collaborative Project.

Reply via email to