Author: huhai <[email protected]>
Date: Tue May 15 15:15:06 2018 +0800
blk-mq: remove unnecessary judgement from blk_mq_make_request
Whether q->elevator is true or not, we can use blk_mq_sched_insert_request
to complete the work.
Signed-off-by: huhai <[email protected]>
diff --git a/block/blk-mq.c b/block/blk-mq.c
index fcf2f16..2545081 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1580,15 +1580,6 @@ static void blk_mq_bio_to_request(struct request *rq,
struct bio *bio)
blk_account_io_start(rq, true);
}
-static inline void blk_mq_queue_io(struct blk_mq_hw_ctx *hctx,
- struct blk_mq_ctx *ctx,
- struct request *rq)
-{
- spin_lock(&ctx->lock);
- __blk_mq_insert_request(hctx, rq, false);
- spin_unlock(&ctx->lock);
-}
-
static blk_qc_t request_to_qc_t(struct blk_mq_hw_ctx *hctx, struct request *rq)
{
if (rq->tag != -1)
@@ -1775,15 +1766,10 @@ static blk_qc_t blk_mq_make_request(struct
request_queue *q, struct bio *bio)
blk_mq_put_ctx(data.ctx);
blk_mq_bio_to_request(rq, bio);
blk_mq_try_issue_directly(data.hctx, rq, &cookie);
- } else if (q->elevator) {
+ } else {
blk_mq_put_ctx(data.ctx);
blk_mq_bio_to_request(rq, bio);
blk_mq_sched_insert_request(rq, false, true, true, true);
- } else {
- blk_mq_put_ctx(data.ctx);
- blk_mq_bio_to_request(rq, bio);
- blk_mq_queue_io(data.hctx, data.ctx, rq);
- blk_mq_run_hw_queue(data.hctx, true);
}
return cookie;