On Tue, Jun 26, 2018 at 02:16:26AM +0000, Bart Van Assche wrote:
> On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote:
> > I run SRP test on Fedora 27, and not run any LIO specific commands
> > to load it, seems it is done automatically.
> >
> > So looks it might not a good idea to fail SRP test if LIO is loaded,
> > just wondering why your SRP test can't make the two co-exist?
>
> The LIO configuration is system-wide. Only one configuration can be
> loaded at any given time. I don't think that the SRP tests should wipe
> any existing LIO configuration data if e.g. blktests is run accidentally
> on a production server. I think that wiping LIO configuration data should
> be a manual step.
I think this should be handled in requires(). I.e. check if LIO is
already configured and then skip the test if it is.
Byte,
Johannes
--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
