On Wed, Aug 1, 2018 at 2:57 AM Hannes Reinecke <h...@suse.de> wrote: > On 08/01/2018 03:00 AM, Ed Cashin wrote: > > On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke <h...@suse.de > > <mailto:h...@suse.de>> wrote: > > > > Use device_add_disk_with_groups() to avoid a race condition with > > udev during startup. > > > > > > I love the idea of getting rid of the race, but I am having trouble > > seeing what happened to the cleanup we had via sysfs_remove_group. > > You're storing a pointer to groups off the device, but I don't see it > > getting > > used for cleanup later in this patch set. Are you patching linux-next? > > > And that's the beauty of this patch: you don't need to free/unlink the > groups yourself. > Unlinking is done in the driver core via > device_del()->device_remove_attrs()->device_remove_groups(). > > So no separate patch needed. >
OK, thanks for the clarification. -- Ed Cashin <ecas...@noserose.net>
