On Wed, 2018-08-08 at 16:21 +0800, Ming Lei wrote: > On Tue, Aug 07, 2018 at 03:51:25PM -0700, Bart Van Assche wrote: > > The RQF_PREEMPT flag is used for three purposes: > > - In the SCSI core, for making sure that power management requests > > are executed if a device is in the "quiesced" state. > > - For domain validation by SCSI drivers that use the parallel port. > > - In the IDE driver, for IDE preempt requests. > > I think the above description may not be accurate, BLK_MQ_REQ_PREEMPT is > always set inside scsi_execute(), that means any scsi_execute() callers > can use the flag of RQF_PREEMPT, of course, not limited to the above > three cases.
Hello Ming, What I described is for which cases we really need the RQF_PREEMPT flag rather than in which cases the RQF_PREEMPT flag is set today. I think we should split the RQF_PREEMPT flag into three flags, one flag per case mentioned above. Bart.
