On 2018/8/10 4:26 PM, shenghui wrote: > > > On 08/10/2018 03:23 PM, Coly Li wrote: >> There are many function definitions do not have identifier argument names, >> scripts/checkpatch.pl complains warnings like this, >> >> WARNING: function definition argument 'struct bcache_device *' should >> also have an identifier name >> #16735: FILE: writeback.h:120: >> +void bch_sectors_dirty_init(struct bcache_device *); >> >> This patch adds identifier argument names to all bcache function >> definitions to fix such warnings. >> >> Signed-off-by: Coly Li <col...@suse.de> >> Cc: Shenghui Wang <shh...@foxmail.com> >> --- >> drivers/md/bcache/bcache.h | 112 +++++++++++++++--------------- >> drivers/md/bcache/bset.h | 126 +++++++++++++++++++--------------- >> drivers/md/bcache/btree.c | 6 +- >> drivers/md/bcache/btree.h | 80 ++++++++++----------- >> drivers/md/bcache/debug.h | 6 +- >> drivers/md/bcache/extents.h | 6 +- >> drivers/md/bcache/journal.h | 20 +++--- > > In journal.c, there is: > 585 static void journal_write(struct closure *); > > In super.c, there is: > 2150 static ssize_t register_bcache(struct kobject *, struct kobj_attribute *, > 2151 const char *, size_t); > >
Nice catch, it will be fixed in v3 series. Thanks. Coly Li
