On Thu, Aug 16, 2018 at 03:45:29PM -0700, Chaitanya Kulkarni wrote:
> This patch removes the duplicate initialization of q->queue_head
> in the blk_alloc_queue_node(). This removes the 2nd initialization
> so that we preserve the initialization order same as declaration
> present in struct request_queue.

Reviewed-by: Omar Sandoval <osan...@fb.com>

> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulka...@wdc.com>
> ---
>  block/blk-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 21c7cb35d3b4..dee56c282efb 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t 
> gfp_mask, int node_id,
>                   laptop_mode_timer_fn, 0);
>       timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);
>       INIT_WORK(&q->timeout_work, NULL);
> -     INIT_LIST_HEAD(&q->queue_head);
>       INIT_LIST_HEAD(&q->timeout_list);
>       INIT_LIST_HEAD(&q->icq_list);
>  #ifdef CONFIG_BLK_CGROUP
> -- 
> 2.17.0
> 

Reply via email to