Re: [PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request()

[Christoph Hellwig]

Looks good,

Reviewed-by: Christoph Hellwig <h...@lst.de>

But one very minor nitpick below:

>  #ifdef CONFIG_PM
> +static inline void blk_pm_request_resume(struct request_queue *q)
> +{
> +     if (q->dev && (q->rpm_status == RPM_SUSPENDED ||
> +                    q->rpm_status == RPM_SUSPENDING))

I usually try to break lines around related conditions, so more something
like:

        if (q->dev &&
            (q->rpm_status == RPM_SUSPENDED || q->rpm_status == RPM_SUSPENDING))