On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote:
> On 10/4/18 11:35 AM, Bart Van Assche wrote:
> > When debugging e.g. the SCSI timeout handler it is important that
> > requests that have not yet been started or that already have
> > completed are also reported through debugfs.
> 
> Thanks, I like this better - applied. BTW, what's up with the
> reverse ordering on this:
> 
> > Signed-off-by: Bart Van Assche <bvanass...@acm.org>
> > Cc: Christoph Hellwig <h...@lst.de>
> > Cc: Ming Lei <ming....@redhat.com>
> > Cc: Hannes Reinecke <h...@suse.com>
> > Cc: Johannes Thumshirn <jthumsh...@suse.de>
> > Cc: Martin K. Petersen <martin.peter...@oracle.com>
> 
> For some reason that really annoys me, and I see it in various
> patches these days. IMHO the SOB should be last, with whatever
> acks, reviews, CC, before that.

I could've sworn that this guideline was even documented somewhere, but
I can't find it now ¯\_(ツ)_/¯

Reply via email to