> > On 9 Oct 2018, at 18.12, Matias Bjørling <[email protected]> wrote: > >>> }; >>> >>> struct pblk_sec_meta { >>> - u64 reserved; >>> __le64 lba; >>> }; >> It's nice to reduce the required metadata size, but this silently >> breaks pblk the on-disk-storage format. We can't have that. >> I suggest breaking out this change as a separate patch that also >> increases SMETA_VERSION_MAJOR and instructs the user via the kernel >> log to migrate the data manually (or factory reset the decice/pblk >> instance). > > In that case, we should include the initialization values of the target > somewhere. E.g., line metadata, or some FTL log to be implemented at some > point. > > Another fix for now will be to keep it as 16b, and do the patch that > you propose later. Igor, I believe the metadata will fit? 16b per LBA > should be max 1K in the case of 64 LBAs.
Ideally, we fit this on the smta structure too, independently of the FTL log. THis way, we can have different line types that are recovered differently. Since we are changing the format, this is a good time to add it. Javier
signature.asc
Description: Message signed with OpenPGP
