On 10/15/18 9:40 AM, Richard Weinberger wrote:
Christoph,
[CC'ing also Anton, he improved the old driver a lot.]
I was just about to start testing it :)
Anton, this patch is based on:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/?h=mq-conversions
Thanks. I remember an RFC patch going across the mailing list during the
summer, but did not know where did this work get to.
Am Montag, 15. Oktober 2018, 08:56:37 CEST schrieb Christoph Hellwig:
There is no good reason to create a scatterlist in the ubd driver,
it can just iterate the request directly.
Signed-off-by: Christoph Hellwig <h...@lst.de>
---
Now that we have the blk-mq conversion something like the patch below
should help to simplify the driver even further.
hm, this breaks UML.
Every filesystem fails to mount.
I did some very rough tests, it seems that the driver fails to read
data correctly as soon the upper layer tries to get more than 4096 bytes
at once out of the block device.
IOW:
dd if=/dev/ubda bs=4096 count=1 skip=0 2>/dev/null| md5sum -
is good.
As soon I set bs to something greater it returns garbage.
Later this day I might have some cycles left to debug further.
I will have some time to look into this in the afternoon, but I have to
have a look at the mq-conversions first.
Thanks,
//richard
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
