On 10/15/18 4:27 AM, Ming Lei wrote: > On Thu, Oct 11, 2018 at 10:58:59AM -0600, Jens Axboe wrote: >> @@ -947,9 +970,12 @@ static int ubd_add(int n, char **error_out) >> >> err = 0; >> out: >> + blk_mq_free_tag_set(&ubd_dev->tag_set); >> +out1: >> return err; >> >> out_cleanup: >> + blk_mq_free_tag_set(&ubd_dev->tag_set); >> blk_cleanup_queue(ubd_dev->queue); > > blk_mq_free_tag_set() should have been put after blk_cleanup_queue().
Doesn't matter for this error path, but I do agree in general that should be the case. I'll fix those up. -- Jens Axboe
