RE: [PATCH v8] virtio_blk: add discard and write zeroes support

Sun, 28 Oct 2018 20:21:48 -0700 


> -----Original Message-----
> From: Christoph Hellwig [mailto:[email protected]]
> Sent: Friday, October 26, 2018 4:27 PM
> To: Paolo Bonzini <[email protected]>
> Cc: Christoph Hellwig <[email protected]>; Daniel Verkamp
> <[email protected]>; Jens Axboe <[email protected]>; Michael S. Tsirkin
> <[email protected]>; [email protected]; linux-
> [email protected]; Stefan Hajnoczi <[email protected]>; Liu, Changpeng
> <[email protected]>
> Subject: Re: [PATCH v8] virtio_blk: add discard and write zeroes support
> 
> On Fri, Oct 26, 2018 at 01:28:54AM +0200, Paolo Bonzini wrote:
> > On 15/10/2018 11:27, Christoph Hellwig wrote:
> > > There is some issues in this spec.  For one using the multiple ranges
> > > also for write zeroes is rather inefficient.  Write zeroes really should
> > > use the same format as read and write.
> >
> > What makes it inefficient?
> 
> We require a memory allocation for each write zeroes instead of encoding
> the lba/len in the command.
Make sense to me, but need to change the spec first.






















					Reply via email to