On Tue, 2018-10-30 at 12:02 -0400, Theodore Y. Ts'o wrote:
> On Tue, Oct 30, 2018 at 08:02:55AM -0700, Bart Van Assche wrote:
> > Details about how the build fails on 32-bit systems would have been welcome
> > in the commit message. Anyway:
> > 
> > Reviewed-by: Bart Van Assche <[email protected]>
> 
> For the record, here's the failure.  It's the usual incomprehensible
> C++ error reporting.  :-)
> 
> [ ... ]
> discontiguous-io.cpp: In function 'int main(int, char**)':
> discontiguous-io.cpp:294:34: error: no matching function for call to 
> 'min(long unsigned int, size_t)'
>          std::min(4ul, len - i * 4));
>                                   ^
> [ ... ]

Thanks Ted for having provided the full compiler output. However, I don't
think that the entire error message should go in the commit message. To me,
the part of the compiler error message I cited tells the whole story :-)

Bart.

Reply via email to