On 11/29/18 10:04 AM, Christoph Hellwig wrote:
> On Thu, Nov 29, 2018 at 10:02:25AM -0700, Jens Axboe wrote:
>> On 11/29/18 8:47 AM, Christoph Hellwig wrote:
>>>> +static inline int nvme_next_ring_index(struct nvme_queue *nvmeq, u16
>>>> index)
>>>> +{
>>>> + if (++index == nvmeq->q_depth)
>>>> + return 0;
>>>> +
>>>> + return index;
>>>> +}
>>>
>>> This is unused now.
>>
>> Huh, wonder how I missed that. GCC must not have complained.
>
> gcc never warns about unused static inline functions. Which makes a lot
> of sense at least for headers..
Not so much for non-headers :-)
>>> Also what about this little cleanup on top?
>>
>> That looks good, I like it. With that, can I add your reviewed-by? I'll
>> run a sanity check on it first.
>
> Reviewed-by: Christoph Hellwig <[email protected]>
Thanks!
--
Jens Axboe
