On Thu, 2018-12-06 at 10:02 -0800, Bart Van Assche wrote: > On Thu, 2018-12-06 at 10:48 -0700, Jens Axboe wrote: > > which would result in a non-zero exit, which should be expected for this > > test? > > Test srp/002 simulates network failures while running fio on top of dm-mpath. > Since queue_if_no_path is enabled in multipath.conf dm-mpath will keep > retrying > the block layer requests it receives if these requests fail due to path > removal. > If fio reports "io_u error" for this test then that means that the test > failed. > I haven't seen fio reporting any I/O errors for this test with any upstream > kernel that I tested in the past year or so.
Hi Jens, Please also verify that the version of multipath-tools that you are running includes the following patch: >From a2675025ae9f652b005345b9082f5042b32c992c Mon Sep 17 00:00:00 2001 From: Bart Van Assche <[email protected]> Date: Fri, 18 Nov 2016 13:33:44 -0800 Subject: [PATCH] Avoid that reloading a map sporadically triggers I/O errors Avoid that reloading a map while there are no paths triggers a flush and hence unwanted I/O errors if 'queue_if_no_path' is enabled. Fixes: commit d569988e7528 ("libmultipath: Fixup 'DM_DEVICE_RELOAD' handling") Signed-off-by: Bart Van Assche <[email protected]> --- libmultipath/devmapper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c index 9b6b0537ba6d..1576dd017d6a 100644 --- a/libmultipath/devmapper.c +++ b/libmultipath/devmapper.c @@ -392,7 +392,7 @@ int dm_addmap_reload(struct multipath *mpp, char *params, int flush) params, ADDMAP_RO, SKIP_KPARTX_OFF); } if (r) - r = dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, flush, + r = dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, !flush, 1, udev_flags, 0); return r; }
