On Wed, Nov 14, 2018 at 09:51:36AM -0800, Bart Van Assche wrote: > Regarding this patch: I think this patch introduces a subtle but severe bug > in the SCSI core, namely that if an abort is processed concurrently with > request completion with "fake timeout" enabled that the abort is ignored.
That requires the following occur concurrently: 1. A real completion 2. A real timeout 3. A fake timeout That can't happen on a production kernel, and highly improbable on the fake one. We can still fix it by having scsi timeout return BLK_EH_RESET_TIMER in this case. I didn't like adding code just to work around error injection, but there isn't a good alternative at the moment.
