On Thu, 2018-12-06 at 07:52 -0800, Christoph Hellwig wrote: > Most SCSI drivers want to enable "clustering", that is merging of > segments so that they might span more than a single page. Remove the > ENABLE_CLUSTERING define, and require drivers to explicitly set > DISABLE_CLUSTERING to disable this feature. All drivers not setting > use_clustering at all are switched to set DISABLE_CLUSTERING to keep > the current behavior.
Was this patch produced manually or has it been generated with the help of a script? In the latter case it would help if that script would be included in the patch description. Additionally, this patch would be much easier to review if it would be split into two patches, one that adds .use_clustering = DISABLE_CLUSTERING from SCSI templates that implicitly disable clustering and a second patch that removes .use_clustering = ENABLE_CLUSTERING from all SCSI drivers. Thanks, Bart.
