On 12/16/18 2:35 AM, Chengguang Xu wrote: > blk_mq_init_queue() will not return NULL pointer to its caller, > so it's better to replace IS_ERR_OR_NULL using IS_ERR in loop_add(). > > If in the future things change to check NULL pointer inside loop_add(), > we should return -ENOMEM as return code instead of PTR_ERR(NULL).
That won't change, I really dislike functions that return NULL if they also return an ERR_PTR. Applied, thanks. -- Jens Axboe
