On 09/01/2019 02:35, Damien Le Moal wrote:
> From: Shin'ichiro Kawasaki <[email protected]>
> +_test_dev_is_zoned() {
> + local zoned_file="${TEST_DEV_SYSFS}/queue/zoned"
> + if grep -q -e "none" "${zoned_file}" ; then
Nit: I think we can leave the zoned_file variable out
if grep -qe "none" "${TEST_DEV_SYSFS}/queue/zoned"; then
[...]
works as well and is a bit more descriptive
--
Johannes Thumshirn SUSE Labs Filesystems
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
