On 1/17/19 11:23 AM, Omar Sandoval wrote:
> On Thu, Jan 10, 2019 at 06:37:13PM +0900, Shin'ichiro Kawasaki wrote:
>> Fio zbd zone mode is necessary for zoned block devices. Introduce the
>> helper function _have_fio_zbd_zonemode() to check that the installed
>> fio version supports the option --zonemode=zbd.
> 
> Testing version numbers is fragile. How about
> 
> if ! fio --cmdhelp=zonemode | grep -q zbd; then
>       SKIP_REASON="Fio version too old (does not support --zonemode=zbd)"
>       return 1
> fi

OK. Will change as suggested. Thanks!

-- 
Best Regards,
Shin'ichiro Kawasaki

Reply via email to