> +int __bio_add_pc_page(struct request_queue *q, struct bio *bio, struct page
> +                   *page, unsigned int len, unsigned int offset,
> +                   bool put_same_page)

Very odd indentation, we try to never have a linebreak between the type
and its parameter name.

> +static inline int bio_add_pc_page(struct request_queue *q, struct bio *bio, 
> struct page
> +                 *page, unsigned int len, unsigned int offset)
> +{
> +     return __bio_add_pc_page(q, bio, page, len, offset, false);
> +}

Too long line.  Also please keep bio_add_pc_page in bio.c and export
it instead of the low-level helper.

Reply via email to