From: Sagi Grimberg <[email protected]>

In case nvme_alloc_ns fails after we initialize ns_head but before we
add the ns to the controller namespaces list we need to explicitly put
the ns_head reference because when we teardown the controller we
won't find it, causing us to leak a dangling subsystem eventually.

Signed-off-by: Sagi Grimberg <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
---
 drivers/nvme/host/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index dc1641247b17..d57a84f45ed0 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3304,6 +3304,7 @@ static int nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned 
nsid)
        mutex_lock(&ctrl->subsys->lock);
        list_del_rcu(&ns->siblings);
        mutex_unlock(&ctrl->subsys->lock);
+       nvme_put_ns_head(ns->head);
  out_free_id:
        kfree(id);
  out_free_queue:
-- 
2.20.1

Reply via email to