On 3/20/19 7:19 AM, Johannes Thumshirn wrote: > On 20/03/2019 12:47, Jan Kara wrote: >> On Wed 20-03-19 09:53:10, Johannes Thumshirn wrote: >>> On 20/03/2019 09:51, Hannes Reinecke wrote: >>>> Yeah, should work, too. >>>> But we should be calling bio_uninit() for all bios. >>> >>> Yup, probably. >>> >>>> Will you be sending an updated patch? >>> >>> Let's wait what other's thing first. >> >> FWIW I'm OK with either solution. Yours seems a bit more future-proof so I >> like it a bit more. > > FWIW Bit 13 for the Flag doesn't work, need to find a free one before > doing a proper submission.
Yeah, you're going to overlap and crash... We really should have a build bug on for that. We don't have any free ones. I've got a patch in io_uring-next that uses the last one. That said, I do greatly prefer your approach to solving the issue. -- Jens Axboe
