On 3/22/19 5:12 PM, Yi Zhang wrote: > Some kernel may not have zoned sysfs node, e.g. RHEL7, checking if > it exists first in _test_dev_is_zoned. > > Signed-off-by: Yi Zhang <[email protected]> > --- > check | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/check b/check > index f0ca382..459104d 100755 > --- a/check > +++ b/check > @@ -405,7 +405,7 @@ _call_test() { > } > > _test_dev_is_zoned() { > - if grep -qe "none" "${TEST_DEV_SYSFS}/queue/zoned" ; then > + if [[ ! -f "${TEST_DEV_SYSFS}/queue/zoned" ]] || grep -qe "none" > "${TEST_DEV_SYSFS}/queue/zoned" ; then > SKIP_REASON="${TEST_DEV} is not a zoned block device" > return 1 > fi
Hi Yi Zhang. This patch looks good for me. I have prepared Debian oldstable environment with kernel 3.16, which does not support "zoned" sysfs attribute. With this kernel, test cases that has test_devices() function and does not have CAN_BE_ZONED=1 flag are skipped. This skip is not expected, and the patch avoids it. -- Best Regards, Shin'ichiro Kawasaki
