On Tue, 2019-04-30 at 21:28 -0700, Chaitanya Kulkarni wrote: > -#define BLKTRACESETUP32 _IOWR(0x12, 115, struct compat_blk_user_trace_setup) > + > +/* XXX: temp work around for RFC */ > +#define BLKTRACESETUP32 _IOWR(0x13, 115, struct compat_blk_user_trace_setup)
This change breaks user space so this change is not acceptable. I think you want to introduce a new ioctl instead of modifying an existing ioctl. Additionally, have you considered to split the blktrace_api.h header file into two header files: one with kernel-internal definitions and a second one with definitions that are shared with user space (include/uapi/...)? Thanks, Bart.
