On 19-05-31 10:27:56, Ming Lei wrote:
> The 'host_tagset' can be set on scsi_debug device for testing
> shared hostwide tags on multiple blk-mq hw queue.
>
> Signed-off-by: Ming Lei <ming....@redhat.com>
> ---
> drivers/scsi/scsi_debug.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index d323523f5f9d..8cf3f6c3f4f9 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -665,6 +665,7 @@ static bool have_dif_prot;
> static bool write_since_sync;
> static bool sdebug_statistics = DEF_STATISTICS;
> static bool sdebug_wp;
> +static bool sdebug_host_tagset = false;
Hi Ming,
I think we can leave it without an initialisation just like the others above.
>
> static unsigned int sdebug_store_sectors;
> static sector_t sdebug_capacity; /* in sectors */
> @@ -4468,6 +4469,7 @@ module_param_named(vpd_use_hostno,
> sdebug_vpd_use_hostno, int,
> module_param_named(wp, sdebug_wp, bool, S_IRUGO | S_IWUSR);
> module_param_named(write_same_length, sdebug_write_same_length, int,
> S_IRUGO | S_IWUSR);
> +module_param_named(host_tagset, sdebug_host_tagset, bool, S_IRUGO | S_IWUSR);
>
> MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert");
> MODULE_DESCRIPTION("SCSI debug adapter driver");
> @@ -5779,6 +5781,7 @@ static int sdebug_driver_probe(struct device *dev)
> sdbg_host = to_sdebug_host(dev);
>
> sdebug_driver_template.can_queue = sdebug_max_queue;
> + sdebug_driver_template.host_tagset = sdebug_host_tagset;
> if (!sdebug_clustering)
> sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
Otherwise: It looks good to me in host tagset point of view.
Reviewed-by: Minwoo Im <minwoo.im....@gmail.com>
