You are welcome.
> On Jun 29, 2019, at 12:46 PM, Florian Knauf
> <[email protected]> wrote:
>
> I have now, on the latest staging master (test log attached, everything
> green), and also learned a lesson about looking more thoroughly for automated
> test cases. That's a mea culpa, I suppose. :P
>
> Before this I'd only found the Linux Test Project, which (if I'm not
> mistaken) contains tests that use loopback devices but no tests that
> specifically test the loopback driver itself. Given the small scope of the
> change, we then considered it sufficient to test manually that the loop
> device still worked and that the max_loop parameter was handled correctly. Of
> course, the blktests way is better.
>
> Thanks for taking the time to answer and review.
>
>> Am 25.06.19 um 21:24 schrieb Chaitanya Kulkarni:
>> I believe you have tested this patch with loop testcases present in the
>> :- https://github.com/osandov/blktests/tree/master/tests/loop.
>> With that, looks good.
>> Reviewed-by: Chaitanya Kulkarni <[email protected]>.
>>> On 06/25/2019 10:55 AM, Florian Knauf wrote:
>>> This patch removes the deprecated simple_strtol function from the option
>>> parsing logic in the loopback device driver. Instead kstrtoint is used to
>>> parse int max_loop, to ensure that input values it cannot represent are
>>> ignored.
>>>
>>> Signed-off-by: Florian Knauf <[email protected]>
>>> Signed-off-by: Christian Ewert <[email protected]>
>>> ---
>>> Thank you for your feedback.
>>>
>>> There's no specific reason to use kstrtol, other than the fact that we
>>> weren't yet aware that kstrtoint exists. (We're new at this, I'm afraid.)
>>>
>>> We've amended the patch to make use of kstrtoint, which is of course much
>>> more straightforward.
>>>
>>> drivers/block/loop.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
>>> index 102d79575895..adfaf4ad37d1 100644
>>> --- a/drivers/block/loop.c
>>> +++ b/drivers/block/loop.c
>>> @@ -2289,7 +2289,7 @@ module_exit(loop_exit);
>>> #ifndef MODULE
>>> static int __init max_loop_setup(char *str)
>>> {
>>> - max_loop = simple_strtol(str, NULL, 0);
>>> + kstrtoint(str, 0, &max_loop);
>>> return 1;
>>> }
>>>
>>>
> <check.log>
