On Mon, Aug 12, 2019 at 1:39 PM Julia Suvorova <[email protected]> wrote: > diff --git a/src/include/liburing/barrier.h b/src/include/liburing/barrier.h > index 98be9e5..4f3d1d7 100644 > --- a/src/include/liburing/barrier.h > +++ b/src/include/liburing/barrier.h > @@ -23,7 +23,7 @@ after the acquire operation executes. This is implemented > using > /* From tools/include/linux/compiler.h */ > /* Optimization barrier */ > /* The "volatile" is due to gcc bugs */ > -#define barrier() __asm__ __volatile__("": : :"memory") > +#define io_uring_barrier() __asm__ __volatile__("": : :"memory") > > /* From tools/virtio/linux/compiler.h */ > #define WRITE_ONCE(var, val) \
Please prefix WRITE_ONCE() and READ_ONCE() with IO_URING_ as well. They are fairly likely to be used in code derived from the Linux kernel. Otherwise: Reviewed-by: Stefan Hajnoczi <[email protected]>
