The static structure queue_attr_group is used only once, when it is passed as the second argument to the function sysfs_create_group(). However, the second parameter of sysfs_create_group() is already defined as constant. Hence make queue_attr_group itself constant, as it is never modified. Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <[email protected]> --- block/blk-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index 977c659dcd18..9401b0cc2e29 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -783,7 +783,7 @@ static umode_t queue_attr_visible(struct kobject *kobj, struct attribute *attr, return attr->mode; } -static struct attribute_group queue_attr_group = { +static const struct attribute_group queue_attr_group = { .attrs = queue_attrs, .is_visible = queue_attr_visible, }; -- 2.19.1
