2019年8月13日(火) 19:33 Pavel Machek <[email protected]>: > > On Sun 2019-08-11 02:55:01, Akinobu Mita wrote: > > This allows LEDs to be controlled by block device activity. > > > > We already have ledtrig-disk (LED disk activity trigger), but the lower > > level disk drivers need to utilize ledtrig_disk_activity() to make the > > LED blink. > > > > The LED block device trigger doesn't require the lower level drivers to > > have any instrumentation. The activity is collected by polling the disk > > stats. > > > > Example: > > > > echo block-nvme0n1 > /sys/class/leds/diy/trigger > > Some machines have lots of block devices... Should we perhaps have > "echo block > trigger; echo nvme0n1 > device"?
I originally considered doing so, just like ledtrig-netdev. However, it turned out that we needed an additional mechanism to mediate between the led trigger registration and the block device unregistration.
