On Tue, 2019-09-03 at 01:57 -0700, Christoph Hellwig wrote:
> On Wed, Aug 28, 2019 at 11:29:44AM +0900, Damien Le Moal wrote:
> > For block devices that do not specify required features, preserve the
> > current default elevator selection (mq-deadline for single queue
> > devices, none for multi-queue devices). However, for devices specifying
> > required features (e.g. zoned block devices ELEVATOR_F_ZBD_SEQ_WRITE
> > feature), select the first available elevator providing the required
> > features.
> > 
> > In all cases, default to "none" if no elevator is available or if the
> > initialization of the default elevator fails.
> > 
> > Signed-off-by: Damien Le Moal <damien.lem...@wdc.com>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <h...@lst.de>

Thanks, but I need to fix this patch too.
The "if (q->nr_hw_queues != 1)" at the beginning of elevator_init_mq()
must be removed.

I am sending a v3 with this fix and a modified patch 5 to call
elevator_init_mq() earlier in device_add_disk().

-- 
Damien Le Moal
Western Digital Research

Reply via email to