We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain <mcg...@kernel.org>
---
 drivers/block/brd.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 530b31240203..6065f493876f 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -372,6 +372,7 @@ static int brd_alloc(int i)
        struct brd_device *brd;
        struct gendisk *disk;
        char buf[DISK_NAME_LEN];
+       int err = -ENOMEM;
 
        mutex_lock(&brd_devices_mutex);
        list_for_each_entry(brd, &brd_devices, brd_list) {
@@ -422,16 +423,20 @@ static int brd_alloc(int i)
        /* Tell the block layer that this is not a rotational device */
        blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
        blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
-       add_disk(disk);
+       err = add_disk(disk);
+       if (err)
+               goto out_cleanup_disk;
 
        return 0;
 
+out_cleanup_disk:
+       blk_cleanup_disk(disk);
 out_free_dev:
        mutex_lock(&brd_devices_mutex);
        list_del(&brd->brd_list);
        mutex_unlock(&brd_devices_mutex);
        kfree(brd);
-       return -ENOMEM;
+       return err;
 }
 
 static void brd_probe(dev_t dev)
-- 
2.30.2


Reply via email to