On 8/2/23 6:30?AM, Christoph Hellwig wrote: > Given that pmem simply loops over an arbitrarily large bio I think > we also need a threshold for which to allow nowait I/O. While it > won't block for giant I/Os, doing all of them in the submitter > context isn't exactly the idea behind the nowait I/O.
You can do a LOT of looping over a giant bio and still come out way ahead compared to needing to punt to a different thread. So I do think it's the right choice. But I'm making assumptions here on what it looks like, as I haven't seen the patch... > Btw, please also always add linux-block to the Cc list for block > driver patches that are even the slightest bit about the block > layer interface. Indeed. Particularly for these nowait changes, as some of them have been pretty broken in the past. -- Jens Axboe
